Use isMethod instead of a direct comparison #1775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is neater if we use the dedicated method available in the Request class
|
This patch could also be applied to the 2.1 branch. |
weaverryan
added a commit
that referenced
this pull request
Oct 2, 2012
|
Hi Albert! Cool! I've patched this into the 2.0 branch at sha: 28e1113 I also changed a few other locations where I found this as well as changing the string to be Thanks! |
|
Rather - I patched against the 2.1 branch - not the 2.0 branch. Old habit :) Thanks! |
|
Thanks, yeah, i agree that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is neater if we use the dedicated method available in the Request class as of 2.1